Applying the QE feedback for the Logging guide #35885

MichalMaler · 2023-09-12T14:59:20Z

Applying the QE feedback for the Logging guide and fixing one badly applied asciidoc markup aspect that needed some escaping.

michelle-purcell

@MichalMaler - LGTM 👍

cescoffier · 2023-09-13T06:59:53Z

The CI issue is odd, but might be related:

2023-09-12T15:45:16.6001505Z [INFO] --- exec-maven-plugin:3.0.0:exec (assemble-downstream-doc) @ quarkus-documentation ---
2023-09-12T15:45:17.9662991Z Sep 12, 2023 3:45:17 PM io.quarkus.docs.generation.AssembleDownstreamDocumentation main
2023-09-12T15:45:17.9664895Z ERROR: Unable to read generated file ../target/asciidoc/generated/config/quarkus-log-logging-log-config.adoc
2023-09-12T15:45:18.0107264Z ##[error]Exception in thread "main" java.io.UncheckedIOException: An error occurred while generating the downstream tree
2023-09-12T15:45:18.0278490Z 	at io.quarkus.docs.generation.AssembleDownstreamDocumentation.main(AssembleDownstreamDocumentation.java:189)
2023-09-12T15:45:18.0281913Z Caused by: java.nio.file.NoSuchFileException: ../target/asciidoc/generated/config/quarkus-log-logging-log-config.adoc
2023-09-12T15:45:18.0282617Z 	at java.base/sun.nio.fs.UnixException.translateToIOException(UnixException.java:92)
2023-09-12T15:45:18.0283531Z 	at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:111)
2023-09-12T15:45:18.0304886Z 	at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:116)
2023-09-12T15:45:18.0305599Z 	at java.base/sun.nio.fs.UnixFileSystemProvider.newByteChannel(UnixFileSystemProvider.java:219)
2023-09-12T15:45:18.0306161Z 	at java.base/java.nio.file.Files.newByteChannel(Files.java:371)
2023-09-12T15:45:18.0306619Z 	at java.base/java.nio.file.Files.newByteChannel(Files.java:422)
2023-09-12T15:45:18.0307179Z 	at java.base/java.nio.file.spi.FileSystemProvider.newInputStream(FileSystemProvider.java:420)
2023-09-12T15:45:18.0307726Z 	at java.base/java.nio.file.Files.newInputStream(Files.java:156)
2023-09-12T15:45:18.0308206Z 	at java.base/java.nio.file.Files.newBufferedReader(Files.java:2839)
2023-09-12T15:45:18.0326020Z 	at java.base/java.nio.file.Files.readAllLines(Files.java:3330)
2023-09-12T15:45:18.0326498Z 	at java.base/java.nio.file.Files.readAllLines(Files.java:3370)
2023-09-12T15:45:18.0327174Z 	at io.quarkus.docs.generation.AssembleDownstreamDocumentation.copyAsciidoc(AssembleDownstreamDocumentation.java:266)
2023-09-12T15:45:18.0328021Z 	at io.quarkus.docs.generation.AssembleDownstreamDocumentation.main(AssembleDownstreamDocumentation.java:167)
2023-09-12T15:45:18.0363788Z [ERROR] Command execution failed.
2023-09-12T15:45:18.0366136Z org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1)
2023-09-12T15:45:18.0366812Z     at org.apache.commons.exec.DefaultExecutor.executeInternal (DefaultExecutor.java:404)
2023-09-12T15:45:18.0368036Z     at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:166)
2023-09-12T15:45:18.0369063Z     at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:982)
2023-09-12T15:45:18.0369657Z     at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:929)
2023-09-12T15:45:18.0372024Z     at org.codehaus.mojo.exec.ExecMojo.execute (ExecMojo.java:457)
2023-09-12T15:45:18.0378164Z     at com.gradle.maven.cache.extension.d.c.a (SourceFile:27)
2023-09-12T15:45:18.0381606Z     at com.gradle.maven.cache.extension.d.n.a (SourceFile:23)
2023-09-12T15:45:18.0382915Z     at com.gradle.maven.cache.extension.d.h.a (SourceFile:28)
2023-09-12T15:45:18.0419806Z     at com.gradle.maven.cache.extension.d.m.a (SourceFile:27)
2023-09-12T15:45:18.0420407Z     at com.gradle.maven.cache.extension.d.a.c (SourceFile:115)
2023-09-12T15:45:18.0420874Z     at com.gradle.maven.cache.extension.d.a.a (SourceFile:61)
2023-09-12T15:45:18.0421329Z     at com.gradle.maven.cache.extension.d.e.a (SourceFile:27)
2023-09-12T15:45:18.0421782Z     at com.gradle.maven.cache.extension.d.l.a (SourceFile:17)
2023-09-12T15:45:18.0424024Z     at com.gradle.maven.cache.extension.d.d.a (SourceFile:42)
2023-09-12T15:45:18.0424618Z     at com.gradle.maven.cache.extension.d.b.a (SourceFile:26)
2023-09-12T15:45:18.0425074Z     at com.gradle.maven.cache.extension.d.f$1.run (SourceFile:35)
2023-09-12T15:45:18.0425960Z     at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute (SourceFile:29)
2023-09-12T15:45:18.0427224Z     at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute (SourceFile:26)
2023-09-12T15:45:18.0428286Z     at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute (SourceFile:66)
2023-09-12T15:45:18.0428919Z     at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute (SourceFile:59)
2023-09-12T15:45:18.0429577Z     at org.gradle.internal.operations.DefaultBuildOperationRunner.execute (SourceFile:157)
2023-09-12T15:45:18.0430429Z     at org.gradle.internal.operations.DefaultBuildOperationRunner.execute (SourceFile:59)
2023-09-12T15:45:18.0431080Z     at org.gradle.internal.operations.DefaultBuildOperationRunner.run (SourceFile:47)
2023-09-12T15:45:18.0432350Z     at com.gradle.maven.cache.extension.d.f.a (SourceFile:31)
2023-09-12T15:45:18.0432810Z     at com.gradle.maven.cache.extension.d.k.a (SourceFile:67)
2023-09-12T15:45:18.0433295Z     at com.gradle.maven.cache.extension.h.b.lambda$createProxy$0 (SourceFile:79)
2023-09-12T15:45:18.0433765Z     at com.sun.proxy.$Proxy140.execute (Unknown Source)
2023-09-12T15:45:18.0434268Z     at com.gradle.maven.scan.extension.internal.d.a.executeMojo (SourceFile:114)
2023-09-12T15:45:18.0435375Z     at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:370)
2023-09-12T15:45:18.0436148Z     at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:351)
2023-09-12T15:45:18.0436735Z     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
2023-09-12T15:45:18.0437742Z     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:171)
2023-09-12T15:45:18.0439096Z     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:163)
2023-09-12T15:45:18.0439885Z     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
2023-09-12T15:45:18.0440705Z     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
2023-09-12T15:45:18.0519706Z     at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
2023-09-12T15:45:18.0520642Z     at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
2023-09-12T15:45:18.0521252Z     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:299)
2023-09-12T15:45:18.0522295Z     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:193)
2023-09-12T15:45:18.0522781Z     at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:106)
2023-09-12T15:45:18.0523263Z     at org.apache.maven.cli.MavenCli.execute (MavenCli.java:963)
2023-09-12T15:45:18.0523736Z     at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
2023-09-12T15:45:18.0524396Z     at org.apache.maven.cli.MavenCli.main (MavenCli.java:199)
2023-09-12T15:45:18.0525080Z     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
2023-09-12T15:45:18.0526200Z     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
2023-09-12T15:45:18.0527006Z     at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
2023-09-12T15:45:18.0527914Z     at java.lang.reflect.Method.invoke (Method.java:566)
2023-09-12T15:45:18.0528470Z     at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
2023-09-12T15:45:18.0529121Z     at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
2023-09-12T15:45:18.0529779Z     at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
2023-09-12T15:45:18.0530823Z     at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
2023-09-12T15:45:18.0531958Z     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
2023-09-12T15:45:18.0532749Z     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
2023-09-12T15:45:18.0534101Z     at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
2023-09-12T15:45:18.0535137Z     at java.lang.reflect.Method.invoke (Method.java:566)
2023-09-12T15:45:18.0535664Z     at org.apache.maven.wrapper.BootstrapMainStarter.start (BootstrapMainStarter.java:52)
2023-09-12T15:45:18.0536446Z     at org.apache.maven.wrapper.WrapperExecutor.execute (WrapperExecutor.java:161)
2023-09-12T15:45:18.0537035Z     at org.apache.maven.wrapper.MavenWrapperMain.main (MavenWrapperMain.java:73)

Signed-off-by: Michal Maléř <[email protected]>

github-actions · 2023-09-15T10:40:31Z

🙈 The PR is closed and the preview is expired.

rsvoboda · 2023-09-15T12:41:15Z

GH based render is weird (cant handle + properly?) - https://github.com/quarkusio/quarkus/blob/main/docs/src/main/asciidoc/logging.adoc#logging-categories

rsvoboda · 2023-09-15T12:44:54Z

when is https://quarkus.io/version/main/ updated to check how the new changes get rendered? @gsmet / @cescoffier
https://quarkus.io/version/main/guides/logging#logging-categories

Ladicek · 2023-09-15T13:22:21Z

That is funny. I checked in the IntelliJ Asciidoc preview and it looked correctly there. I don't know whose Asciidoc renderer is at fault, but + is clearly a part of the language: https://docs.asciidoctor.org/asciidoc/latest/pass/pass-macro/

MichalMaler · 2023-09-15T13:24:53Z

It all works on main local Quarkus docs build.

GitHub preview allows only simplistic asciidoc, since it is more designed towards markdown.

@Ladicek @rsvoboda I did my checks and it renders fine.

rsvoboda · 2023-09-17T15:55:21Z

https://quarkus.io/version/main/guides/logging#logging-categories doesn't render well, that's what users see

Ladicek · 2023-09-18T06:43:20Z

That's terrible. @MichalMaler is there another way to do this?

MichalMaler · 2023-09-18T08:48:27Z

@rsvoboda @Ladicek Not sure why it works on my build and not at the Quarkus one, but sure, let me find another combo.

MichalMaler · 2023-09-18T15:23:30Z

@rsvoboda Hello Rostislav:
To solve this issue, I proposed two PRs that fix this problem:

Enhancements to Configuration section of the Logging guide #35988 Rewriting the text so that sentence that lists the handlers categories with the wildcard (*) is not used at all and I replaced it with new content. SME reviewed by @cescoffier , Dev reviewed by @jmartisk .
Rewriting a sentece to a bullet list and applying a asciidoc escape macro to ensure proper rendering #35995 Keeping the text as it is, jut rephrasing that one sentence into a bullet list. There, to be sure, I am using an asciidoc pass[] macro to escape the rendering of that *. Renders fine as you can see here (GitHub Quarkus preview bot) https://quarkus-pr-main-35995-preview.surge.sh/version/main/guides/logging#logging-categories

It is up to the community what they will use now.

rsvoboda · 2023-09-19T06:16:39Z

Is there a support to have conditional branching similar to if - else? @gsmet / @cescoffier
upstream render => old text
product render => new text with +

…oud-jsonlogging!18) This MR contains the following updates: | Package | Type | Update | Change | |---------|------|--------|--------| | [io.quarkus:quarkus-extension-processor](https://github.com/quarkusio/quarkus) | | minor | `3.3.2` -\> `3.4.1` | | [io.quarkus:quarkus-extension-maven-plugin](https://github.com/quarkusio/quarkus) | build | minor | `3.3.2` -\> `3.4.1` | | [io.quarkus:quarkus-bom](https://github.com/quarkusio/quarkus) | import | minor | `3.3.2` -\> `3.4.1` | | [io.quarkus:quarkus-maven-plugin](https://github.com/quarkusio/quarkus) | build | minor | `3.3.2` -\> `3.4.1` | | [org.eclipse.parsson:parsson](https://github.com/eclipse-ee4j/parsson) | compile | patch | `1.1.2` -\> `1.1.4` | | [io.smallrye.common:smallrye-common-constraint](http://smallrye.io) ([source](https://github.com/smallrye/smallrye-common)) | compile | patch | `2.1.0` -\> `2.1.2` | --- ### Release Notes <details> <summary>quarkusio/quarkus</summary> ### [`v3.4.1`](https://github.com/quarkusio/quarkus/releases/tag/3.4.1) [Compare Source](quarkusio/quarkus@3.4.0...3.4.1) ##### Major changes - [\#35732](quarkusio/quarkus#35732) - Rework how to enable/activate Flyway ##### Complete changelog - [\#36000](quarkusio/quarkus#36000) - Bump org.eclipse.jgit:org.eclipse.jgit from 6.6.0.202305301015-r to 6.6.1.202309021850-r in /docs - [\#35999](quarkusio/quarkus#35999) - Bump org.eclipse.jgit:org.eclipse.jgit from 6.6.0.202305301015-r to 6.6.1.202309021850-r in /bom/application - [\#35990](quarkusio/quarkus#35990) - Don't ignore empty SSE events in client - [\#35987](quarkusio/quarkus#35987) - Improve the way HTTP authorizer logs exceptions - [\#35981](quarkusio/quarkus#35981) - Fix link to AWS Lambda SnapStart in documentation - [\#35979](quarkusio/quarkus#35979) - Add `@ConfigDocEnumValue` & `@ConfigDocDefault` to writing-extensions guide - [\#35977](quarkusio/quarkus#35977) - Recompute cached value when the Redis connection fails - [\#35975](quarkusio/quarkus#35975) - OIDC: AuthenticationRedirectionException after successful login - [\#35968](quarkusio/quarkus#35968) - Warn when wrong token proxy is accessed - [\#35966](quarkusio/quarkus#35966) - SSE: Reactive SseEventSource client doesn't consume empty events - [\#35964](quarkusio/quarkus#35964) - OIDC: NPE when accessing IdToken when Bearer access token is sent - [\#35959](quarkusio/quarkus#35959) - Log invalid CORS origin and method - [\#35958](quarkusio/quarkus#35958) - \[GraalVM 24.0\] Hibernate ORM elasticsearch native integration tests fail with return type mismatch - [\#35956](quarkusio/quarkus#35956) - Fix return type of hibernate-search substitution - [\#35949](quarkusio/quarkus#35949) - Properly initialize reactive Pool beans - [\#35938](quarkusio/quarkus#35938) - Bump org.apache.commons:commons-compress from 1.23.0 to 1.24.0 in /bom/application - [\#35937](quarkusio/quarkus#35937) - Bump org.apache.commons:commons-compress from 1.23.0 to 1.24.0 in /independent-projects/tools - [\#35926](quarkusio/quarkus#35926) - Fix use of multiple `@ClientXXX` annotations in REST Client Reactive - [\#35925](quarkusio/quarkus#35925) - Add a property to bypass cache mechanism in case of Redis failure - [\#35919](quarkusio/quarkus#35919) - Honor OIDC logout requests when ID token has expired - [\#35914](quarkusio/quarkus#35914) - Prevent recording configuration coming from Gradle - [\#35900](quarkusio/quarkus#35900) - Fix RESTEasy CDI dependency issue - [\#35899](quarkusio/quarkus#35899) - Add note about unsupported `@Lock` in Spring Data JPA - [\#35895](quarkusio/quarkus#35895) - Update liquibase to 4.23.2, liquibase-mongodb to 4.23.1 - [\#35889](quarkusio/quarkus#35889) - UriInfo can not be injected in presence of quarkus-rest-client dependency - [\#35886](quarkusio/quarkus#35886) - OTel Scope.close() warning improvement - [\#35885](quarkusio/quarkus#35885) - Applying the QE feedback for the Logging guide - [\#35884](quarkusio/quarkus#35884) - Application fails to start when eactive restclient uses both ClientExceptionMapper and ClientObjectMapper - [\#35883](quarkusio/quarkus#35883) - Bring back the HTTP console commands - [\#35879](quarkusio/quarkus#35879) - Quarkus 3.4.0.CR1 does not have HTTP commands in dev mode - [\#35858](quarkusio/quarkus#35858) - NullPointerException when entity primary key has the type `byte[]` - [\#35777](quarkusio/quarkus#35777) - Add a note about HR not being a replacement for ORM - [\#35732](quarkusio/quarkus#35732) - Rework how to enable/activate Flyway - [\#35728](quarkusio/quarkus#35728) - OIDC logout not working for virtual callback paths, if id_token is expired but session cookie is present - [\#35690](quarkusio/quarkus#35690) - Upgrade to Hibernate ORM 6.2.9.Final and HR 2.0.5.Final - [\#35655](quarkusio/quarkus#35655) - Flyway does not work without default datasource 3.3 - [\#35528](quarkusio/quarkus#35528) - flyway with one supported and one unsupported Db throws exception at startup ### [`v3.4.0`](https://github.com/quarkusio/quarkus/releases/tag/3.4.0) [Compare Source](quarkusio/quarkus@3.3.3...3.4.0) ##### Complete changelog - [\#35888](quarkusio/quarkus#35888) - Restore missing parameters in OIDC Dev UI client cred and password SwaggerUI/GraphQL handlers - [\#35870](quarkusio/quarkus#35870) - Use default Vert.x client settings in OTel exporters - [\#35866](quarkusio/quarkus#35866) - Automatic TLS support in new Vert.x based open telemetry implementation - [\#35862](quarkusio/quarkus#35862) - Only remove OTLP trace services when otlp is not configured - [\#35846](quarkusio/quarkus#35846) - Fixes aggregation of configurations with two different executions ids - [\#35844](quarkusio/quarkus#35844) - Improve description of the duration format in configuration documentation - [\#35840](quarkusio/quarkus#35840) - Updates Infinispan to 14.0.17.Final - [\#35831](quarkusio/quarkus#35831) - Quarkus aggregate configurations from different executions that share the same goal - [\#35822](quarkusio/quarkus#35822) - Check that embedded property types are marked as `@Embeddable` - [\#35817](quarkusio/quarkus#35817) - Improve Qute + Cache integration - [\#35804](quarkusio/quarkus#35804) - HTTP fix response compression support - [\#35792](quarkusio/quarkus#35792) - Do not include in the list of property names Kubernetes config fallbacks - [\#35789](quarkusio/quarkus#35789) - Improve OTel Sampler docs - [\#35786](quarkusio/quarkus#35786) - OpenTelemetry exporter (otlp) startup dependency error when running as a Docker container image - [\#35784](quarkusio/quarkus#35784) - Document the ability to automatically compress rotated log files - [\#35778](quarkusio/quarkus#35778) - Fix generic handling of ParamConverter - [\#35774](quarkusio/quarkus#35774) - RESTEasy Reactive fails to handle collections of parameterized types as parameter - [\#35764](quarkusio/quarkus#35764) - Do not include revision and host-specific info in MANIFEST.MF - [\#35762](quarkusio/quarkus#35762) - Delete temporary openshift files - [\#35759](quarkusio/quarkus#35759) - Upgrade Smallrye OpenAPI to 3.5.2 - [\#35757](quarkusio/quarkus#35757) - Update liquibase from 4.20.0 to 4.23.1, liquibase-mongodb to 4.23.0 - [\#35747](quarkusio/quarkus#35747) - Large files remain in /tmp after OpenShift deployments - [\#35726](quarkusio/quarkus#35726) - Improve matching of config properties to a root - [\#35722](quarkusio/quarkus#35722) - Since quarkus 3.3.0 a WARN message unrecognized configuration key "quarkus.kubernetes.route.expose" is logged - [\#35718](quarkusio/quarkus#35718) - Packs libraries alongside executable in function.zip - [\#35713](quarkusio/quarkus#35713) - AWS Lambda extension does not pack necessary .so files when AWT is used - [\#35710](quarkusio/quarkus#35710) - Fix potential NPE in HTTP proxying - [\#35706](quarkusio/quarkus#35706) - Azure-Functions crash when X-Forwarded headers are enabled java.lang.NullPointerException - [\#35599](quarkusio/quarkus#35599) - Keycloak/Quarkus Issues: Dev and Prod - [\#35598](quarkusio/quarkus#35598) - Improve Error-Message for missing Embedabbles - [\#35558](quarkusio/quarkus#35558) - Widen conditions under RESTEasy Reactive Server and RESTEasy Classic Client can work together - [\#12260](quarkusio/quarkus#12260) - Quarkus logging with compress option ### [`v3.3.3`](https://github.com/quarkusio/quarkus/releases/tag/3.3.3) [Compare Source](quarkusio/quarkus@3.3.2...3.3.3) ##### Complete changelog - Fixes CVE-2023-4853 - [\#35490](quarkusio/quarkus#35490) - Build cache - Improve cachability of service binding tests </details> <details> <summary>eclipse-ee4j/parsson</summary> ### [`v1.1.4`](eclipse-ee4j/parsson@1.1.3...1.1.4) [Compare Source](eclipse-ee4j/parsson@1.1.3...1.1.4) ### [`v1.1.3`](https://github.com/eclipse-ee4j/parsson/releases/tag/1.1.3): Parsson 1.1.3 [Compare Source](eclipse-ee4j/parsson@1.1.2...1.1.3) #### What's Changed - 1\.1.2 release by [@lukasj](https://github.com/lukasj) in eclipse-ee4j/parsson#89 - [\#91](eclipse-ee4j/parsson#91): Stack overflow error caused by jakarta.json parsing of untrusted JSON String by [@lukasj](https://github.com/lukasj) in eclipse-ee4j/parsson#92 - update build plugins by [@lukasj](https://github.com/lukasj) in eclipse-ee4j/parsson#93 - improve compatibility with OSGi mediator by [@lukasj](https://github.com/lukasj) in eclipse-ee4j/parsson#96 - [\#77](eclipse-ee4j/parsson#77): JsonTokenizer.close() recycles its buffer for each call to close() by [@lukasj](https://github.com/lukasj) in eclipse-ee4j/parsson#97 - [\#90](eclipse-ee4j/parsson#90): MapUtil.handle does not support Array objects by [@lukasj](https://github.com/lukasj) in eclipse-ee4j/parsson#98 **Full Changelog**: eclipse-ee4j/parsson@1.1.2...1.1.3 </details> <details> <summary>smallrye/smallrye-common</summary> ### [`v2.1.2`](https://github.com/smallrye/smallrye-common/releases/tag/2.1.2) [Compare Source](smallrye/smallrye-common@2.1.1...2.1.2) - [\#243](smallrye/smallrye-common#243) Release 2.1.2 - [\#242](smallrye/smallrye-common#242) Fix substitutions for Windows OS - [\#241](smallrye/smallrye-common#241) GraalVM substitution problem on Windows - [\#240](smallrye/smallrye-common#240) Bump version.vertx from 4.4.4 to 4.4.5 ### [`v2.1.1`](https://github.com/smallrye/smallrye-common/releases/tag/2.1.1) [Compare Source](smallrye/smallrye-common@2.1.0...2.1.1) - [\#239](smallrye/smallrye-common#239) Release 2.1.1 - [\#238](smallrye/smallrye-common#238) Allow reaper threads to be started at run time - [\#237](smallrye/smallrye-common#237) Bump io.sundr:sundr-maven-plugin from 0.100.1 to 0.100.3 - [\#236](smallrye/smallrye-common#236) Bump org.apache.maven:maven-artifact from 3.9.3 to 3.9.4 - [\#234](smallrye/smallrye-common#234) Bump version.graalvm from 22.3.2 to 23.0.1 - [\#233](smallrye/smallrye-common#233) Bump module-info from 2.0 to 2.1 - [\#232](smallrye/smallrye-common#232) Bump sundr-maven-plugin from 0.95.0 to 0.100.1 - [\#231](smallrye/smallrye-common#231) Bump maven-artifact from 3.9.2 to 3.9.3 - [\#230](smallrye/smallrye-common#230) Bump version.vertx from 4.4.3 to 4.4.4 - [\#227](smallrye/smallrye-common#227) Bump smallrye-parent from 39 to 40 - [\#226](smallrye/smallrye-common#226) Bump version.vertx from 4.4.1 to 4.4.3 - [\#225](smallrye/smallrye-common#225) Bump sundr-maven-plugin from 0.94.0 to 0.95.0 - [\#222](smallrye/smallrye-common#222) Bump maven-artifact from 3.9.0 to 3.9.2 - [\#221](smallrye/smallrye-common#221) Port quiet(...) and cast(...) methods from wildfly-common - [\#220](smallrye/smallrye-common#220) Bump version.graalvm from 22.3.1 to 22.3.2 - [\#218](smallrye/smallrye-common#218) Bump version.vertx from 4.4.0 to 4.4.1 - [\#217](smallrye/smallrye-common#217) Bump asm from 9.4 to 9.5 - [\#216](smallrye/smallrye-common#216) Support unsigned parameter range checks - [\#214](smallrye/smallrye-common#214) Bump version.vertx from 4.3.8 to 4.4.0 </details> --- ### Configuration :date: **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Enabled. :recycle: **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. :ghost: **Immortal**: This MR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- * [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.hypersistence:hypersistence-utils-hibernate-62](https://github.com/vladmihalcea/hypersistence-utils) | compile | patch | `3.5.2` -> `3.5.3` | | [org.hibernate.orm:hibernate-envers](https://hibernate.org/orm) ([source](https://github.com/hibernate/hibernate-orm)) | build | patch | `6.3.0.Final` -> `6.3.1.Final` | | [org.hibernate.orm:hibernate-core](https://hibernate.org/orm) ([source](https://github.com/hibernate/hibernate-orm)) | build | patch | `6.3.0.Final` -> `6.3.1.Final` | | [io.quarkus:quarkus-maven-plugin](https://github.com/quarkusio/quarkus) | build | minor | `3.3.3` -> `3.4.1` | | [io.quarkus:quarkus-universe-bom](https://github.com/quarkusio/quarkus-platform) | import | minor | `3.3.3` -> `3.4.1` | --- ### Release Notes <details> <summary>vladmihalcea/hypersistence-utils</summary> ### [`v3.5.3`](https://github.com/vladmihalcea/hypersistence-utils/blob/HEAD/changelog.txt#Version-353---September-19-2023) \================================================================================ Add QueryStackTraceLogger that allows you to locate the source of an SQL query executed by Hibernate [#653](vladmihalcea/hypersistence-utils#653) </details> <details> <summary>hibernate/hibernate-orm</summary> ### [`v6.3.1.Final`](https://github.com/hibernate/hibernate-orm/blob/HEAD/changelog.txt#Changes-in-631Final-September-19-2023) [Compare Source](hibernate/hibernate-orm@6.3.0...6.3.1) https://hibernate.atlassian.net/projects/HHH/versions/32188 \*\* Bug \* \[HHH-17221] - AssertionError initializing a collection with FetchMode.SUBSELECT and IdClass having only one field \* \[HHH-17203] - ElementCollection doesn't consider [@Where](https://github.com/Where) annotation on delete of elements \* \[HHH-17202] - ArrayStoreException for single field id class entity collection batch loading \* \[HHH-17201] - Unexpected value type exception for unordered multi id Load with ordered return disable \* \[HHH-17189] - Audited annotations are ignored on embeddable super types \* \[HHH-17177] - JDBC type code is ignored in XML mapping for an id attribute \* \[HHH-17173] - Getting one-to-one association through a referenece to a bytecode enhanced entity fails \* \[HHH-17168] - Investigate failures on db10\_5 and Cockrachdb of FunctionTests.testCastBinaryWithLength \* \[HHH-17167] - Unable to locate parameter for RESTRICT - DELETE error when removing entity with RowId \* \[HHH-17166] - query methods returning primitive types incorrectly inferred to be mutation query methods \* \[HHH-17165] - short method names in metamodel generator cause SIOBE \* \[HHH-17163] - persist() should throw JPA's EntityExistsException if passed detached instance \* \[HHH-17159] - java.lang.StackOverflowError during Update on Entity with Embeddable and JSON \* \[HHH-17156] - NPE when an Embeddable column is reused in another class related by inheritance \* \[HHH-17154] - NullPointerException is thrown when constructing EntityManagerFactoryBuilderImpl \* \[HHH-17135] - CriteriaQuery error passing nullLiteral with entity type class \* \[HHH-17131] - Regression in entity streams with associated collections resulting in result duplication \* \[HHH-17105] - SQL clause from [@WhereJoinTable](https://github.com/WhereJoinTable) is no longer used for DELETE queries (6.2 regression) \* \[HHH-17104] - Bug with max() request inside projection \* \[HHH-17100] - CustomType wrongly calls UserType#disassemble \* \[HHH-17080] - \[Envers] AuditReader.getRevisionNumberForDate(LocalDateTime) uses Epoch Seconds instead of Epoch Millis \* \[HHH-17079] - NPE when using CompositeUserType with generic fields in Hibernate 6 \* \[HHH-17049] - Bytecode Enhancement, extra records created for associations created in constructor \* \[HHH-16945] - CTE query cycle attribute evaluated incorrectly on MSSQL using collation "Latin1\_General_CI_AS" \* \[HHH-15968] - Sporadic ClassCastException when querying for Set<Enum>. \*\* Improvement \* \[HHH-17220] - Avoid runtime lookups of JdbcService from TableGenerator and TableStructure \* \[HHH-17171] - JPA and multiple query roots \* \[HHH-16768] - HQL parsed predicates don't validate type comparability \*\* Task \* \[HHH-17204] - Relax visibility of some methods for reactive upsert() support \* \[HHH-17187] - Avoid 0 byte trailing UUID's in tests \* \[HHH-17160] - Gradle 8.3 upgrade \* \[HHH-17087] - Update container images to the latest version </details> <details> <summary>quarkusio/quarkus</summary> ### [`v3.4.1`](https://github.com/quarkusio/quarkus/releases/tag/3.4.1) [Compare Source](quarkusio/quarkus@3.4.0...3.4.1) ##### Major changes - [#35732](quarkusio/quarkus#35732) - Rework how to enable/activate Flyway ##### Complete changelog - [#36000](quarkusio/quarkus#36000) - Bump org.eclipse.jgit:org.eclipse.jgit from 6.6.0.202305301015-r to 6.6.1.202309021850-r in /docs - [#35999](quarkusio/quarkus#35999) - Bump org.eclipse.jgit:org.eclipse.jgit from 6.6.0.202305301015-r to 6.6.1.202309021850-r in /bom/application - [#35990](quarkusio/quarkus#35990) - Don't ignore empty SSE events in client - [#35987](quarkusio/quarkus#35987) - Improve the way HTTP authorizer logs exceptions - [#35981](quarkusio/quarkus#35981) - Fix link to AWS Lambda SnapStart in documentation - [#35979](quarkusio/quarkus#35979) - Add `@ConfigDocEnumValue` & `@ConfigDocDefault` to writing-extensions guide - [#35977](quarkusio/quarkus#35977) - Recompute cached value when the Redis connection fails - [#35975](quarkusio/quarkus#35975) - OIDC: AuthenticationRedirectionException after successful login - [#35968](quarkusio/quarkus#35968) - Warn when wrong token proxy is accessed - [#35966](quarkusio/quarkus#35966) - SSE: Reactive SseEventSource client doesn't consume empty events - [#35964](quarkusio/quarkus#35964) - OIDC: NPE when accessing IdToken when Bearer access token is sent - [#35959](quarkusio/quarkus#35959) - Log invalid CORS origin and method - [#35958](quarkusio/quarkus#35958) - \[GraalVM 24.0] Hibernate ORM elasticsearch native integration tests fail with return type mismatch - [#35956](quarkusio/quarkus#35956) - Fix return type of hibernate-search substitution - [#35949](quarkusio/quarkus#35949) - Properly initialize reactive Pool beans - [#35938](quarkusio/quarkus#35938) - Bump org.apache.commons:commons-compress from 1.23.0 to 1.24.0 in /bom/application - [#35937](quarkusio/quarkus#35937) - Bump org.apache.commons:commons-compress from 1.23.0 to 1.24.0 in /independent-projects/tools - [#35926](quarkusio/quarkus#35926) - Fix use of multiple `@ClientXXX` annotations in REST Client Reactive - [#35925](quarkusio/quarkus#35925) - Add a property to bypass cache mechanism in case of Redis failure - [#35919](quarkusio/quarkus#35919) - Honor OIDC logout requests when ID token has expired - [#35914](quarkusio/quarkus#35914) - Prevent recording configuration coming from Gradle - [#35900](quarkusio/quarkus#35900) - Fix RESTEasy CDI dependency issue - [#35899](quarkusio/quarkus#35899) - Add note about unsupported `@Lock` in Spring Data JPA - [#35895](quarkusio/quarkus#35895) - Update liquibase to 4.23.2, liquibase-mongodb to 4.23.1 - [#35889](quarkusio/quarkus#35889) - UriInfo can not be injected in presence of quarkus-rest-client dependency - [#35886](quarkusio/quarkus#35886) - OTel Scope.close() warning improvement - [#35885](quarkusio/quarkus#35885) - Applying the QE feedback for the Logging guide - [#35884](quarkusio/quarkus#35884) - Application fails to start when eactive restclient uses both ClientExceptionMapper and ClientObjectMapper - [#35883](quarkusio/quarkus#35883) - Bring back the HTTP console commands - [#35879](quarkusio/quarkus#35879) - Quarkus 3.4.0.CR1 does not have HTTP commands in dev mode - [#35858](quarkusio/quarkus#35858) - NullPointerException when entity primary key has the type `byte[]` - [#35777](quarkusio/quarkus#35777) - Add a note about HR not being a replacement for ORM - [#35732](quarkusio/quarkus#35732) - Rework how to enable/activate Flyway - [#35728](quarkusio/quarkus#35728) - OIDC logout not working for virtual callback paths, if id_token is expired but session cookie is present - [#35690](quarkusio/quarkus#35690) - Upgrade to Hibernate ORM 6.2.9.Final and HR 2.0.5.Final - [#35655](quarkusio/quarkus#35655) - Flyway does not work without default datasource 3.3 - [#35528](quarkusio/quarkus#35528) - flyway with one supported and one unsupported Db throws exception at startup ### [`v3.4.0`](https://github.com/quarkusio/quarkus/releases/tag/3.4.0) [Compare Source](quarkusio/quarkus@3.3.3...3.4.0) ##### Complete changelog - [#35888](quarkusio/quarkus#35888) - Restore missing parameters in OIDC Dev UI client cred and password SwaggerUI/GraphQL handlers - [#35870](quarkusio/quarkus#35870) - Use default Vert.x client settings in OTel exporters - [#35866](quarkusio/quarkus#35866) - Automatic TLS support in new Vert.x based open telemetry implementation - [#35862](quarkusio/quarkus#35862) - Only remove OTLP trace services when otlp is not configured - [#35846](quarkusio/quarkus#35846) - Fixes aggregation of configurations with two different executions ids - [#35844](quarkusio/quarkus#35844) - Improve description of the duration format in configuration documentation - [#35840](quarkusio/quarkus#35840) - Updates Infinispan to 14.0.17.Final - [#35831](quarkusio/quarkus#35831) - Quarkus aggregate configurations from different executions that share the same goal - [#35822](quarkusio/quarkus#35822) - Check that embedded property types are marked as `@Embeddable` - [#35817](quarkusio/quarkus#35817) - Improve Qute + Cache integration - [#35804](quarkusio/quarkus#35804) - HTTP fix response compression support - [#35792](quarkusio/quarkus#35792) - Do not include in the list of property names Kubernetes config fallbacks - [#35789](quarkusio/quarkus#35789) - Improve OTel Sampler docs - [#35786](quarkusio/quarkus#35786) - OpenTelemetry exporter (otlp) startup dependency error when running as a Docker container image - [#35784](quarkusio/quarkus#35784) - Document the ability to automatically compress rotated log files - [#35778](quarkusio/quarkus#35778) - Fix generic handling of ParamConverter - [#35774](quarkusio/quarkus#35774) - RESTEasy Reactive fails to handle collections of parameterized types as parameter - [#35764](quarkusio/quarkus#35764) - Do not include revision and host-specific info in MANIFEST.MF - [#35762](quarkusio/quarkus#35762) - Delete temporary openshift files - [#35759](quarkusio/quarkus#35759) - Upgrade Smallrye OpenAPI to 3.5.2 - [#35757](quarkusio/quarkus#35757) - Update liquibase from 4.20.0 to 4.23.1, liquibase-mongodb to 4.23.0 - [#35747](quarkusio/quarkus#35747) - Large files remain in /tmp after OpenShift deployments - [#35726](quarkusio/quarkus#35726) - Improve matching of config properties to a root - [#35722](quarkusio/quarkus#35722) - Since quarkus 3.3.0 a WARN message unrecognized configuration key "quarkus.kubernetes.route.expose" is logged - [#35718](quarkusio/quarkus#35718) - Packs libraries alongside executable in function.zip - [#35713](quarkusio/quarkus#35713) - AWS Lambda extension does not pack necessary .so files when AWT is used - [#35710](quarkusio/quarkus#35710) - Fix potential NPE in HTTP proxying - [#35706](quarkusio/quarkus#35706) - Azure-Functions crash when X-Forwarded headers are enabled java.lang.NullPointerException - [#35599](quarkusio/quarkus#35599) - Keycloak/Quarkus Issues: Dev and Prod - [#35598](quarkusio/quarkus#35598) - Improve Error-Message for missing Embedabbles - [#35558](quarkusio/quarkus#35558) - Widen conditions under RESTEasy Reactive Server and RESTEasy Classic Client can work together - [#12260](quarkusio/quarkus#12260) - Quarkus logging with compress option </details> <details> <summary>quarkusio/quarkus-platform</summary> ### [`v3.4.1`](quarkusio/quarkus-platform@3.3.3...3.4.1) [Compare Source](quarkusio/quarkus-platform@3.3.3...3.4.1) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This MR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

MichalMaler requested a review from michelle-purcell September 12, 2023 14:59

quarkus-bot bot added the area/documentation label Sep 12, 2023

MichalMaler requested review from Ladicek and cescoffier September 12, 2023 14:59

MichalMaler added area/docstyle issues related for manual docstyle review triage/backport-3.2 labels Sep 12, 2023

michelle-purcell reviewed Sep 12, 2023

View reviewed changes

Ladicek approved these changes Sep 12, 2023

View reviewed changes

Ladicek added triage/backport? triage/waiting-for-ci Ready to merge when CI successfully finishes labels Sep 12, 2023

gsmet approved these changes Sep 12, 2023

View reviewed changes

michelle-purcell added the triage/needs-vale-rule-tweak label Sep 12, 2023

cescoffier approved these changes Sep 13, 2023

View reviewed changes

MichalMaler force-pushed the QE-feedback-Logging-guide branch from 872bc43 to c0dc060 Compare September 13, 2023 10:24

Applying the QE feedback for the Logging guide

43f5225

Signed-off-by: Michal Maléř <[email protected]>

MichalMaler force-pushed the QE-feedback-Logging-guide branch from c0dc060 to 43f5225 Compare September 15, 2023 09:17

Ladicek merged commit e3fb90e into quarkusio:main Sep 15, 2023
5 checks passed

quarkus-bot bot added this to the 3.5 - main milestone Sep 15, 2023

quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 15, 2023

MichalMaler deleted the QE-feedback-Logging-guide branch September 15, 2023 11:44

gsmet modified the milestones: 3.5 - main, 3.4.1 Sep 19, 2023

gsmet removed the triage/backport? label Sep 19, 2023

gsmet modified the milestones: 3.4.1, 3.2.7.Final Oct 3, 2023

gsmet removed the triage/backport-3.2 label Oct 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Applying the QE feedback for the Logging guide #35885

Applying the QE feedback for the Logging guide #35885

MichalMaler commented Sep 12, 2023

michelle-purcell left a comment

cescoffier commented Sep 13, 2023

github-actions bot commented Sep 15, 2023 •

edited

Loading

rsvoboda commented Sep 15, 2023 •

edited

Loading

rsvoboda commented Sep 15, 2023

Ladicek commented Sep 15, 2023

MichalMaler commented Sep 15, 2023

rsvoboda commented Sep 17, 2023

Ladicek commented Sep 18, 2023

MichalMaler commented Sep 18, 2023

MichalMaler commented Sep 18, 2023

rsvoboda commented Sep 19, 2023

Applying the QE feedback for the Logging guide #35885

Applying the QE feedback for the Logging guide #35885

Conversation

MichalMaler commented Sep 12, 2023

michelle-purcell left a comment

Choose a reason for hiding this comment

cescoffier commented Sep 13, 2023

github-actions bot commented Sep 15, 2023 • edited Loading

rsvoboda commented Sep 15, 2023 • edited Loading

rsvoboda commented Sep 15, 2023

Ladicek commented Sep 15, 2023

MichalMaler commented Sep 15, 2023

rsvoboda commented Sep 17, 2023

Ladicek commented Sep 18, 2023

MichalMaler commented Sep 18, 2023

MichalMaler commented Sep 18, 2023

rsvoboda commented Sep 19, 2023

github-actions bot commented Sep 15, 2023 •

edited

Loading

rsvoboda commented Sep 15, 2023 •

edited

Loading